Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from LBYL to EAFP style. #188

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Conversation

@NotAFile
Copy link

IMO, list.get() is superior to either method.

@yuvallanger
Copy link
Contributor Author

yuvallanger commented Apr 10, 2018 via email

@non-Jedi
Copy link
Collaborator

This looks like marginal readability improvement to me. Sign-off per contributing.rst, and I can merge.

@non-Jedi
Copy link
Collaborator

LGTM. Thanks!

@non-Jedi non-Jedi merged commit 81b3d7a into matrix-org:master Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants