Add support for rendering a custom wrapper around Element

[maheichyk]

This PR suggests to extend module API with possibility to provide a wrapper component to be rendered arounnd Element.

PR in element web element-hq/element-web#25537 that is linked.

[weeman1337]

Thank you for your contribution @maheichyk .

• There should be another PR in React-SDK to actually display the banner. Can you link it here?
• The banner feature should be mentioned in the README.

[maheichyk]

@weeman1337 thanks for your comments, I have provided the changes. Here is a PR in matrix-react-sdk matrix-org/matrix-react-sdk#10321 that is linked. Is it fine just to keep this link just in a comment or should I move it to the description?

[weeman1337]

@maheichyk sorry this issue got out of sight. Usually the workflow here is to re-request a review one changes are done.

This way it will be on my review list :)

Is it fine just to keep this link just in a comment or should I move it to the description?

For a better discoverability add it to the description please.

[Johennes]

This blocks on element-hq/element-web#25537 (comment).

[maheichyk]

@germain-gg we discussed this PR last Wednesday, it seems to be okay. Could we move this forward?

[germain-gg]

The banner use case makes a lot of sense, but after discussing with other team members internally we believe we would like to make this module a bit more generic.

Rather than a banner, we would like to suggest defining a wrapper.

Similarly to the banner, you should be able to define a React Component that will take on a children prop.
From an implementation point of view it would wrap the MatrixChat component, and let any consumer add a banner, a footer.

This brings the flexibility of a pseudo-iframe without the constraints.

[maheichyk]

@germain-gg thanks a lot for the suggestion, sounds a good idea. I have added WrapperLifecycle and removed the banner related code. Please have a look.

[germain-gg]

Thank you for the updates, couple of changes in the test and that should be ready to be merged.

[germain-gg]

Looks good to me, thank you for updating everything.
That should be good to go 🎉

All review comments have been addressed, and PR has been changed significantly since initial review

[germain-gg]

@maheichyk could you update your branch with the base branch? It's preventing me from merging that pull request otherwise. And I do not have permissions as maintainer to push to your branch.

[maheichyk]

@germain-gg it is updated, thanks for the message

[maheichyk]

@germain-gg thanks for the review and merge! Could you please create a release of the module api, then I could finish: element-hq/element-web#25537

[germain-gg]

@maheichyk It's been released as part of 2.1.0

[fnwbr]

@maheichyk Thank you very much for your work on this! Do you by any chance have a public project that's going to make use of this new feature that you could link? I'd be curious to read up on it, as we might be interested in using this as well.

[maheichyk]

@fnwbr yes, it is used in our opendesk-module that is public since some time now.