Clarify devices affected by notification settings

This clarifies that the notification settings only apply to the current device. This also tries to apply the spirit of #1995 which wanted to remove "web" from the label, since there's also a desktop client.
matrix-org · Mar 26, 2019 · 45e6e49 · 45e6e49
1 parent 7b972e4
commit 45e6e49
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/views/settings/Notifications.js b/src/components/views/settings/Notifications.js
@@ -837,15 +837,15 @@ module.exports = React.createClass({
 
                     <LabelledToggleSwitch value={SettingsStore.getValue("notificationsEnabled")}
                                           onChange={this.onEnableDesktopNotificationsChange}
-                                          label={_t('Enable desktop notifications')} />
+                                          label={_t('Enable desktop notifications for this device')} />
 
                     <LabelledToggleSwitch value={SettingsStore.getValue("notificationBodyEnabled")}
                                           onChange={this.onEnableDesktopNotificationBodyChange}
                                           label={_t('Show message in desktop notification')} />
 
                     <LabelledToggleSwitch value={SettingsStore.getValue("audioNotificationsEnabled")}
                                           onChange={this.onEnableAudioNotificationsChange}
-                                          label={_t('Enable audible notifications in web client')} />
+                                          label={_t('Enable audible notifications for this device')} />
 
                     { emailNotificationsRows }
 

diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json
@@ -497,9 +497,9 @@
     "Advanced notification settings": "Advanced notification settings",
     "There are advanced notifications which are not shown here": "There are advanced notifications which are not shown here",
     "You might have configured them in a client other than Riot. You cannot tune them in Riot but they still apply": "You might have configured them in a client other than Riot. You cannot tune them in Riot but they still apply",
-    "Enable desktop notifications": "Enable desktop notifications",
+    "Enable desktop notifications for this device": "Enable desktop notifications for this device",
     "Show message in desktop notification": "Show message in desktop notification",
-    "Enable audible notifications in web client": "Enable audible notifications in web client",
+    "Enable audible notifications for this device": "Enable audible notifications for this device",
     "Off": "Off",
     "On": "On",
     "Noisy": "Noisy",