Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Initialize line-height for room name on IRC layout #10188

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Initialize line-height for room name on IRC layout #10188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
672f08a
Initialize line-height for room name on IRC layout
luixxiul Feb 20, 2023
1e45c22
Check room name line-height
luixxiul Mar 10, 2023
61df8d9
Test with the default layout
luixxiul Mar 10, 2023
4f498a0
Merge branch 'develop' into IRCLayout-line-height
luixxiul Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cypress/e2e/timeline/timeline.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ describe("Timeline", () => {
"created and configured the room.",
).should("exist");

// Check room name line-height is reset
cy.get(".mx_IRCLayout .mx_NewRoomIntro h2").should("have.css", "line-height", "normal");

cy.get(".mx_MainSplit").percySnapshotElement("Configured room on IRC layout");
});

Expand Down
6 changes: 6 additions & 0 deletions res/css/views/rooms/_IRCLayout.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ $irc-line-height: $font-18px;

line-height: $irc-line-height !important;

.mx_NewRoomIntro {
> h2 {
line-height: initial; /* Cancel $irc-line-height */
}
}

.mx_EventTile {
--EventTile_irc_line-padding-block: 1px;

Expand Down