Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Align info EventTile and normal EventTile on IRC layout #10197

Merged
merged 13 commits into from
Mar 3, 2023
Merged

Align info EventTile and normal EventTile on IRC layout #10197

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
311440c
Reduce spacing values set with var(--right-padding) on mx_EventTile
luixxiul Feb 21, 2023
11e37fa
Remove spacing between profile name and trash bin
luixxiul Feb 21, 2023
323ddd3
For mx_RedactedBody use the inherited value for spacing, instead of t…
luixxiul Feb 21, 2023
31ca16e
Reflect the change to the test
luixxiul Feb 21, 2023
6d289b8
Add a test to check alignment
luixxiul Feb 23, 2023
34d1ad6
Merge branch 'develop' into fix-info-line-spacing-IRClayout
luixxiul Feb 23, 2023
5a8d1fa
Replace percySnapshot with percySnapshotElement
luixxiul Feb 23, 2023
ce32673
Improve the test
luixxiul Feb 23, 2023
d734ae5
Fix what to get
luixxiul Feb 23, 2023
ab00c5f
Add a test for emote
luixxiul Feb 23, 2023
4ec04d5
Check the button's text instead
luixxiul Feb 23, 2023
0041c01
Merge branch 'develop' into fix-info-line-spacing-IRClayout
luixxiul Feb 24, 2023
6b60dfc
Fix percyCSS for emote screenshot
luixxiul Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions cypress/e2e/timeline/timeline.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,16 +202,15 @@ describe("Timeline", () => {
// 3. Alignment of expanded GELS and placeholder of deleted message
// 4. Alignment of expanded GELS, placeholder of deleted message, and emote

// Exclude timestamp from snapshot
const percyCSS =
".mx_RoomView_body .mx_EventTile_info .mx_MessageTimestamp " + "{ visibility: hidden !important; }";
// Exclude timestamp from snapshot of mx_MainSplit
const percyCSS = ".mx_MainSplit .mx_MessageTimestamp { visibility: hidden !important; }";
Copy link
Contributor Author

@luixxiul luixxiul Feb 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should hide timestamps of not only an info event line but also an emote (and a normal event line for messages) for https://percy.io/dfde73bd/matrix-react-sdk/builds/25434742/changed/1418297380?browser=edge&browser_ids=18%2C33%2C34%2C35&subcategories=approved&viewLayout=overlay&viewMode=new&width=1920&widths=400%2C800%2C1024%2C1920.


cy.visit("/#/room/" + roomId);
cy.setSettingValue("layout", null, SettingLevel.DEVICE, Layout.IRC);

// Wait until configuration is finished
cy.contains(
".mx_RoomView_body .mx_GenericEventListSummary " + ".mx_GenericEventListSummary_summary",
".mx_RoomView_body .mx_GenericEventListSummary .mx_GenericEventListSummary_summary",
"created and configured the room.",
).should("exist");

Expand Down