Directly convert Matrix and room Ids to pills #10267
Conversation
weeman1337
added
the
T-Defect
| @@ -89,11 +89,8 @@ export default class TextualBody extends React.Component<IBodyProps, IState> { | |||
| const showLineNumbers = SettingsStore.getValue("showCodeLineNumbers"); | |||
| this.activateSpoilers([this.contentRef.current]); | |||
|
|
|||
| // pillifyLinks BEFORE linkifyElement because plain room/user URLs in the composer | |||
There was a problem hiding this comment.
From element-hq/element-meta#1030
The RTE team have their own issue tracking this version of the work - we will not implement anything in the RTE, instead they will aim to match the behaviour we're implementing. As both composers will likely live alongside each other - this feels like the best approach
weeman1337
force-pushed
the
weeman1337/pillify-everything-directly
branch
from
f75f82b
to
0a154f5
Compare
There was a problem hiding this comment.
Looks good, but I don't understand how this relates to the comment that you are deleting.
The comment says we should do this if the composer pillifies things. The compose doesn't pillify things as you type, but are you saying we should do this anyway? (I think I agree, just want to be clear)
Yes. I would refer to my comment in this PR. We do now pillify it if possible. The new composer will catch up on that. |
Ah OK, now I understand the connection. Thanks, looks good! |
Should be reviewed commit-wise.
closes element-hq/element-web#21867
PSF-1927
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes