This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Add a test to check whether ReadReceiptGroup exists on ThreadView in the bubble layout #10284
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the bubble layout TODO: replace with a test which checks whether ReadReceiptGroup is always visible Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
github-actions
bot
added
the
T-Task
t3chguy
approved these changes
Mar 6, 2023
|
@t3chguy Thanks for the quick review! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#23569 and element-hq/element-web#23326
Follow-up to #9239 (comment):
This PR adds a test which checks whether ReadReceiptGroup exists on
ThreadViewin the bubble layout.After the issue that the read receipt group is hidden on ThreadView in the bubble layout (see: element-hq/element-web#23569 (comment)) is fixed, it should be able to check whether the group is visible. Currently, checking it returns an error because the read receipt overflows the default visible area of
ThreadViewexcept on a large viewport.type: task
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.