This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Conform more of the codebase to strictNullChecks
#10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
florianduros
approved these changes
Apr 12, 2023
| @@ -41,9 +41,9 @@ const CreateSubspaceDialog: React.FC<IProps> = ({ space, onAddExistingSpaceClick | |||
|
|
|||
| const [busy, setBusy] = useState<boolean>(false); | |||
| const [name, setName] = useState(""); | |||
| const spaceNameField = useRef<Field>(); | |||
| const spaceNameField = useRef() as RefObject<Field>; | |||
There was a problem hiding this comment.
Why do we need to cast it ? An issue between MutableRefObject and RefObject ?
There was a problem hiding this comment.
Indeed, plus we don't really want to encourage manual mutation, it should be managed entirely by React and only accessed by us. But yeah without it React + Typescript don't fit the type properly
For some reason MutableRefObject always allows undefined - RefObject always null - things don't seem quite right
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-js-sdk#3271
For element-hq/element-web#21967
This change is marked as an internal change (Task), so will not be included in the changelog.