Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Replace hardcoded strings with MsgType constants #10604

Merged

Conversation

kenwuuu
Copy link
Contributor

@kenwuuu kenwuuu commented Apr 14, 2023

Signed-off-by: Ken Wu kenqiwu@gmail.com


This change is marked as an internal change (Task), so will not be included in the changelog.

@kenwuuu kenwuuu requested a review from a team as a code owner April 14, 2023 09:44
@kenwuuu kenwuuu requested review from richvdh and t3chguy April 14, 2023 09:44
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 14, 2023
@richvdh richvdh added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 14, 2023
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, but please do take a look at the contributing guide (https://github.com/vector-im/element-web/blob/develop/CONTRIBUTING.md) - in particular the section about sign-off.

src/components/views/elements/EventTilePreview.tsx Outdated Show resolved Hide resolved
src/ContentMessages.ts Outdated Show resolved Hide resolved
kenwuuu added 2 commits April 14, 2023 03:18
Signed-off-by: Ken Wu kenqiwu@gmail.com
Signed-off-by: Ken Wu kenqiwu@gmail.com
@kenwuuu kenwuuu requested a review from richvdh April 14, 2023 10:22
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@richvdh richvdh enabled auto-merge April 17, 2023 09:15
@richvdh richvdh added this pull request to the merge queue Apr 17, 2023
Merged via the queue into matrix-org:develop with commit dc4bb23 Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants