Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Replace remaining use of checkDeviceTrust #10716

Merged
merged 4 commits into from
May 3, 2023
Merged

Replace remaining use of checkDeviceTrust #10716

merged 4 commits into from
May 3, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Apr 26, 2023 •
edited by github-actions bot
Loading

Followup to #10663, and the final part of element-hq/element-web#25093.

This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh richvdh requested a review from a team as a code owner April 26, 2023 15:20
@richvdh richvdh changed the title Replace remaining uses of checkDeviceTrust Replace remaining use of checkDeviceTrust Apr 26, 2023
@richvdh richvdh added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 26, 2023
germain-gg
germain-gg approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@artcodespace artcodespace removed their request for review April 27, 2023 07:25
@richvdh richvdh added this pull request to the merge queue Apr 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 27, 2023
@t3chguy t3chguy added this pull request to the merge queue Apr 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 27, 2023
@richvdh
Copy link
Member Author

richvdh commented May 2, 2023

this seems to have a flaky test. will revisit

@richvdh
Copy link
Member Author

richvdh commented May 3, 2023

The flaky test in question was introduced in #10662.

Possibly fixed by #10750, but in any case I think it's unrelated to this PR.

@richvdh richvdh enabled auto-merge May 3, 2023 13:35
@richvdh richvdh added this pull request to the merge queue May 3, 2023
Merged via the queue into develop with commit 42e6c98 May 3, 2023
@richvdh richvdh deleted the rav/element-r/more_device_verification_status branch May 3, 2023 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@andybalaam andybalaam Awaiting requested review from andybalaam andybalaam was automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richvdh @germain-gg