This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add pressable eye in password input to display wrong password #10832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed issue:
Users can make a typing mistake when entering their password.
An error message is then displayed, but the user cannot know where they made a mistake in entering their password since it is hidden.
Proposed solution:
Inside the input (in the right side of it), add an eye icon and when the user presses on it, show the previously hidden password (attention: when the user presses, not click, so that when the user stops touching the eye icon, the password is hidden once again).
Example:
This PR currently has none of the required changelog labels.
A reviewer can add one of:
T-Deprecation
,T-Enhancement
,T-Defect
,T-Task
to indicate what type of change this is, or addType: [enhancement/defect/task]
to the description and I'll add them for you.