Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

aulamber
Copy link

@aulamber aulamber commented May 9, 2023

Addressed issue:
Users can make a typing mistake when entering their password.
An error message is then displayed, but the user cannot know where they made a mistake in entering their password since it is hidden.

Proposed solution:
Inside the input (in the right side of it), add an eye icon and when the user presses on it, show the previously hidden password (attention: when the user presses, not click, so that when the user stops touching the eye icon, the password is hidden once again).

Example:

  • Current behavior
Capture d’écran 2023-05-09 à 14 43 48
  • Proposed solution
  1. without pressing the eye:
Capture d’écran 2023-05-09 à 14 44 07
  1. while pressing the eye
Capture d’écran 2023-05-09 à 14 44 18

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 9, 2023
@t3chguy
Copy link
Member

t3chguy commented May 9, 2023

How does this look on browsers/environments which already have this feature natively?

image

Edit:

Not great
image

@aulamber
Copy link
Author

How does this look on browsers/environments which already have this feature natively?

image Edit:

Not great image

Can you tell us where you reproduce this double eye, on which browser(s) and environment(s)?
For the microsoft eye (the one in your screenshot it seems), we could hide their eye, with this code:

input::-ms-reveal {
  display:none;
}

@t3chguy
Copy link
Member

t3chguy commented May 30, 2023

Can you tell us where you reproduce this double eye, on which browser(s) and environment(s)?

The above was Edge on Windows 11

cc @gsouquet as you mentioned Compound input fields will have a password reveal

@langleyd langleyd closed this Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants