Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Conform more of the codebase to strict typescript #10841

Merged
merged 7 commits into from
May 25, 2023
Merged

Conform more of the codebase to strict typescript #10841

merged 7 commits into from
May 25, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 10, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#21967

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 10, 2023
@t3chguy t3chguy self-assigned this May 11, 2023
@t3chguy t3chguy force-pushed the t3chguy/types666 branch from aa950c6 to 112cb66 Compare May 18, 2023 08:58
@t3chguy t3chguy force-pushed the t3chguy/types666 branch from 112cb66 to 9222dfa Compare May 18, 2023 09:05
@t3chguy t3chguy changed the title Conform more of the codebase to strictNullChecks Conform more of the codebase to strict typescript May 18, 2023
@t3chguy t3chguy force-pushed the t3chguy/types666 branch from 9222dfa to a09dc48 Compare May 18, 2023 09:24
t3chguy added 2 commits May 24, 2023 09:51
@t3chguy
Merge branch 'develop' of https://github.com/matrix-org/matrix-react-sdk
b5375e7 
 into t3chguy/types666

# Conflicts:
#	src/components/views/rooms/EditMessageComposer.tsx
#	src/components/views/rooms/ReadReceiptMarker.tsx
#	src/components/views/rooms/ThirdPartyMemberInfo.tsx
@t3chguy
Merge remote-tracking branch 'origin/t3chguy/types666' into t3chguy/t…
83073df 
…ypes666
@t3chguy t3chguy marked this pull request as ready for review May 24, 2023 14:00
@t3chguy t3chguy requested a review from a team as a code owner May 24, 2023 14:00
@t3chguy t3chguy requested review from andybalaam and germain-gg May 24, 2023 14:00
andybalaam
andybalaam approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@t3chguy t3chguy merged commit 277a3c0 into develop May 25, 2023
@t3chguy t3chguy deleted the t3chguy/types666 branch May 25, 2023 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andybalaam andybalaam andybalaam approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @andybalaam