This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Conform more of the codebase to strictNullChecks
#10842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
added
the
T-Task
artcodespace
approved these changes
May 11, 2023
src/stores/WidgetStore.ts
Outdated
Comment on lines
41
to
44
| export function isAppWidget(widget: IWidget | IApp): widget is IApp { | ||
| return typeof widget["roomId"] === "string"; | ||
| } | ||
|
|
There was a problem hiding this comment.
In a piece of work I started a Typeguards.ts file in the src folder. I'm still not entirely sure if it would be better to put typeguards in one file, or always keep them closer to what they're guarding for, like here.
What do you think? Better to keep here or consolidate in a single typeguards file?
There was a problem hiding this comment.
My personal preference is closer to the object, in you case I think it makes sense for generic ones which don't apply to a specific type, like null
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/element-web#21967
Split into meaningful commits to aid review
This change is marked as an internal change (Task), so will not be included in the changelog.