Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove deprecated intentionalMentions client start option #11048

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Jun 6, 2023

For element-hq/element-web#25497
With: matrix-org/matrix-js-sdk#3445

See js-sdk PR for context

🚨Auto merge enabled

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 6, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review June 7, 2023 00:17
@kerryarchibald kerryarchibald requested a review from a team as a code owner June 7, 2023 00:17
@kerryarchibald kerryarchibald added this pull request to the merge queue Jun 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 7, 2023
@kegsay
Copy link
Member

kegsay commented Jun 7, 2023

Can we merge this please as it is breaking react SDK develop / JS SDK develop from working together as the JS SDK PR has landed already.

@weeman1337 weeman1337 added this pull request to the merge queue Jun 7, 2023
Merged via the queue into develop with commit b2452a4 Jun 7, 2023
@weeman1337 weeman1337 deleted the kerry/25497/mentions-displayname-ping branch June 7, 2023 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants