Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix font-family definition for emojis #11170

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Fix font-family definition for emojis #11170

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6055fa
Fix font-family definition for emojis
Jun 30, 2023
3a46954
prettier fix
Jun 30, 2023
b69978a
Merge branch 'develop' into gsouquet/fix-emoji-font
Jun 30, 2023
24d16f6
Rephrase comment about font family overrides
Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions res/css/_common.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,19 @@ limitations under the License.
--dialog-zIndex-standard: calc(var(--dialog-zIndex-standard-background) + 1); /* 4012 */
}

/**
* Doubling the selector to increase specificity as Compound defines it as such
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to make sense of this comment 🤔 Do you mean that we need increased specificity here to override the value that the design tokens package sets?

*/
[class^="cpd-theme"][class^="cpd-theme"] {
/**
* The design tokens package currently does not expose the fallback fonts
* We want to keep on re-using `$font-family` to not break custom themes
* and because we can to use `Twemoji` to display emoji rather than using
* system ones
*/
--cpd-font-family-sans: $font-family;
}

@media only percy {
:root {
--percy-color-avatar: $username-variant2-color;
Expand Down