This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
DRAFT: Add e2e tests for the module system #11396
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a proposal for testing the Module System with Cypress. It needs to be viewed together with element-hq/element-web#25951.
The changes:
cypress/example_module
(tbd) folder. It has a minimal setup with a package.json, but we don't expect that anyone callsyarn install
we expect it to be used directly as a TypeScript file, so Webpack is advised to run babel for it (-> change in element-web).ELEMENT_BUILD_CONFIG
variable that can change the location of thebuild_config.yaml
file that is used in the build process. Ayarn start:e2e
script is adding theexample_module
created in 1. (-> change in element-web)I added two example tests for the translations and the
RoomViewLifecycle.PreviewRoomNotLoggedIn
lifecycle to show how a test could look like.@germain-gg we discussed this before, and I wanted to propose this so we have a base for our discussions. Do you think this setup would work for us? I would be happy to receive feedback, and other ideas on how to make the module system testable.
Checklist
Type: task
Notes: none
This change is marked as an internal change (Task), so will not be included in the changelog.