Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Minor improvements to unread tests #11491

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Aug 30, 2023

Part of element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@andybalaam andybalaam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Aug 30, 2023
@andybalaam andybalaam requested a review from a team as a code owner August 30, 2023 11:12
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot check looks good

@andybalaam
Copy link
Member Author

The tests that are failing in CI are passing for me locally. I'm going to roll this change right back to comments-only and see whether that works. If so, I'll merge this and make new PRs for the functional changes.

@andybalaam andybalaam force-pushed the andybalaam/improve-comments-in-receipt-tests branch from cc7565a to 10a6475 Compare August 31, 2023 12:36
@andybalaam andybalaam added this pull request to the merge queue Aug 31, 2023
Merged via the queue into develop with commit c7b0850 Aug 31, 2023
19 checks passed
@andybalaam andybalaam deleted the andybalaam/improve-comments-in-receipt-tests branch August 31, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants