This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
More tests for reactions to messages in threads #11612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Sep 18, 2023
andybalaam
requested review from
t3chguy and
weeman1337
and removed request for
a team
September 18, 2023 10:47
t3chguy
approved these changes
Sep 18, 2023
weeman1337
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪿
Test failure looks like an infrastructure flake of some kind:
|
(Or at least it passes for me locally) |
Base automatically changed from
andybalaam/more-tests-for-redactions
to
develop
September 18, 2023 15:41
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#25449
Builds on #11594 but overlap is trivial.
This change is marked as an internal change (Task), so will not be included in the changelog.