This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Split the read-receipt tests into logical units #11649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
added
the
T-Task
andybalaam
force-pushed
the
andybalaam/split-receipt-tests-into-4
branch
from
25cf817
to
82e65c8
Compare
richvdh
approved these changes
Sep 22, 2023
richvdh
reviewed
Sep 22, 2023
| */ | ||
|
|
||
| /* | ||
| * # High Level Read Receipt Tests |
There was a problem hiding this comment.
also, presumably only high-level.spec.ts are "High Level" tests?
There was a problem hiding this comment.
I still consider all of these high level. I avoided renaming the "high-level" file as "misc" because I didn't like that name and it made it easer for me to preserve my later PRs.
I am kind of hoping that when we flesh out more tests inside that file they will earn their own separate files with good names.
There was a problem hiding this comment.
ok. It might be good to create a high-level subdirectory then?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#25449
This should prevent them being super-slow on CI, and crashing Chrome.
This change is marked as an internal change (Task), so will not be included in the changelog.