Render timeline separator for late event groups #11739

t3chguy · 2023-10-12T09:09:00Z

For https://github.com/vector-im/wat-internal/issues/42

Here's what your changelog entry will look like:

✨ Features

Render timeline separator for late event groups (#11739).

…discovery Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

nadonomy

@t3chguy This looks great! Seeing it in chorus with the tooltips, I think we can make the datestamp label way more verbose, which in turn makes the timeline a lot more legible when scanning.

So simply:

Originally sent {{ ... }}

Instead of:

Recovered messages originally sent at {{...}}

Sorry we could've caught that at design time, but hopefully a trivial tweak.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

…act-sdk into t3chguy/fix/25913.3 # Conflicts: # src/components/structures/MessagePanel.tsx # src/components/structures/grouper/CreationGrouper.tsx # src/components/structures/grouper/MainGrouper.tsx # src/components/views/messages/MessageTimestamp.tsx # test/utils/exportUtils/__snapshots__/HTMLExport-test.ts.snap

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

nadonomy

LGTM

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

… t3chguy/fix/25913.3 # Conflicts: # src/components/views/messages/MessageTimestamp.tsx # src/components/views/rooms/EventTile.tsx

… t3chguy/fix/25913.3 # Conflicts: # src/components/structures/MessagePanel.tsx # src/components/structures/grouper/CreationGrouper.tsx # src/components/structures/grouper/MainGrouper.tsx

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

germain-gg

Looks good! Added a few comments, but don't consider them blocking if this needs to go in quickly

res/css/views/messages/_TimelineSeparator.pcss

germain-gg · 2023-10-16T10:03:45Z

res/css/views/messages/_TimelineSeparator.pcss

+    display: flex;
+    align-items: center;
+    font: var(--cpd-font-body-md-regular);
+    color: $roomtopic-color;


Looks like a misuse of $roomtopic-color. Should probably be text secondary or something along those lines

These styles are not new, they're just broken out of 1 file into 2 files

germain-gg · 2023-10-16T12:50:12Z

src/components/views/messages/TimelineSeparator.tsx

+}
+
+const TimelineSeparator: React.FC<Props> = ({ label, children }) => {
+    // ARIA treats <hr/>s as separators, here we abuse them slightly so manually treat this entire thing as one


Sounds like we could and probably should use pseudo elements ::before and ::after in place of <hr /> here.

Yup, possibly, this isn't new code, just moving home

src/components/views/messages/TimelineSeparator.tsx

src/components/structures/grouper/LateEventGrouper.ts

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

@stefanceriu

Changes in [1.11.47](https://github.com/vector-im/element-web/releases/tag/v1.11.47) (2023-10-24) ================================================================================================= ## 🦖 Deprecations * Deprecate customisations in favour of Module API ([\#25736](element-hq/element-web#25736)). Fixes #25733. ## ✨ Features * element-hq/element-x-ios/issues/1824 - Convert the apple-app-site-association file to a newer format… ([\#26307](element-hq/element-web#26307)). Contributed by @stefanceriu. * Iterate `io.element.late_event` decoration ([\#11760](matrix-org/matrix-react-sdk#11760)). Fixes #26384. * Render timeline separator for late event groups ([\#11739](matrix-org/matrix-react-sdk#11739)). * OIDC: revoke tokens on logout ([\#11718](matrix-org/matrix-react-sdk#11718)). Fixes #25394. Contributed by @kerryarchibald. * Show `io.element.late_event` in MessageTimestamp when known ([\#11733](matrix-org/matrix-react-sdk#11733)). * Show all labs flags if developerMode enabled ([\#11746](matrix-org/matrix-react-sdk#11746)). Fixes #24571 and #8498. * Use Compound tooltips on MessageTimestamp to improve UX of date time discovery ([\#11732](matrix-org/matrix-react-sdk#11732)). Fixes #25913. * Consolidate 4s passphrase input fields and use stable IDs ([\#11743](matrix-org/matrix-react-sdk#11743)). Fixes #26228. * Disable upgraderoom command without developer mode enabled ([\#11744](matrix-org/matrix-react-sdk#11744)). Fixes #17620. * Avoid rendering app download buttons if disabled in config ([\#11741](matrix-org/matrix-react-sdk#11741)). Fixes #26309. * OIDC: refresh tokens ([\#11699](matrix-org/matrix-react-sdk#11699)). Fixes #25839. Contributed by @kerryarchibald. * OIDC: register ([\#11727](matrix-org/matrix-react-sdk#11727)). Fixes #25393. Contributed by @kerryarchibald. * Use stable get_login_token and remove unstable MSC3882 support ([\#11001](matrix-org/matrix-react-sdk#11001)). Contributed by @hughns. ## 🐛 Bug Fixes * Set max size for Element logo in search warning ([\#11779](matrix-org/matrix-react-sdk#11779)). Fixes #26408. * Avoid error when DMing oneself ([\#11754](matrix-org/matrix-react-sdk#11754)). Fixes #7242. * Fix: Message shield alignment is not right. ([\#11703](matrix-org/matrix-react-sdk#11703)). Fixes #26142. Contributed by @manancodes. * fix logging full event ([\#11755](matrix-org/matrix-react-sdk#11755)). Fixes #26376. * OIDC: use delegated auth account URL from `OidcClientStore` ([\#11723](matrix-org/matrix-react-sdk#11723)). Fixes #26305. Contributed by @kerryarchibald. * Fix: Members list shield alignment is not right. ([\#11700](matrix-org/matrix-react-sdk#11700)). Fixes #26261. Contributed by @manancodes. * Fix: <detail> HTML elements clickable area too wide. ([\#11666](matrix-org/matrix-react-sdk#11666)). Fixes #25454. Contributed by @manancodes. * Fix untranslated headings in the devtools dialog ([\#11734](matrix-org/matrix-react-sdk#11734)). * Fixes invite dialog alignment and pill color contrast ([\#11722](matrix-org/matrix-react-sdk#11722)). Contributed by @gabrc52. * Prevent select element in General settings overflowing in a room with very long room-id ([\#11597](matrix-org/matrix-react-sdk#11597)). Contributed by @ABHIXIT2. * Fix: Clicking on members pile does nothing. ([\#11657](matrix-org/matrix-react-sdk#11657)). Fixes #26164. Contributed by @manancodes. * Fix: Wierd shadow below room avatar in dark mode. ([\#11678](matrix-org/matrix-react-sdk#11678)). Fixes #26153. Contributed by @manancodes. * Fix start_sso / start_cas URLs failing to redirect to a authentication prompt ([\#11681](matrix-org/matrix-react-sdk#11681)). Contributed by @Half-Shot. Changes in [1.11.46](https://github.com/vector-im/element-web/releases/tag/v1.11.46) (2023-10-10) ================================================================================================= ## ✨ Features * Use .well-known to discover a default rendezvous server for use with Sign in with QR ([\#11655](matrix-org/matrix-react-sdk#11655)). Contributed by @hughns. * Message layout will update according to the selected style ([\#10170](matrix-org/matrix-react-sdk#10170)). Fixes #21782. Contributed by @manancodes. * Implement MSC4039: Add an MSC for a new Widget API action to upload files into the media repository ([\#11311](matrix-org/matrix-react-sdk#11311)). Contributed by @dhenneke. * Render space pills with square corners to match new avatar ([\#11632](matrix-org/matrix-react-sdk#11632)). Fixes #26056. * Linkify room topic ([\#11631](matrix-org/matrix-react-sdk#11631)). Fixes #26185. * Show knock rooms in the list ([\#11573](matrix-org/matrix-react-sdk#11573)). Contributed by @maheichyk. ## 🐛 Bug Fixes * Bump matrix-web-i18n dependency to 3.1.3 ([\#26287](element-hq/element-web#26287)) * Fix: Avatar shrinks with long names ([\#11698](matrix-org/matrix-react-sdk#11698)). Fixes #26252. Contributed by @manancodes. * Update custom translations to support nested fields in structured JSON ([\#11685](matrix-org/matrix-react-sdk#11685)). * Fix: Edited message remove button is hard to reach. ([\#11674](matrix-org/matrix-react-sdk#11674)). Fixes #24917. Contributed by @manancodes. * Fix: Theme selector radio button not aligned in center with the text ([\#11676](matrix-org/matrix-react-sdk#11676)). Fixes #25460. Contributed by @manancodes. * Fix: Unread notification dot aligned ([\#11658](matrix-org/matrix-react-sdk#11658)). Fixes #25285. Contributed by @manancodes. * Fix: sync intentional mentions push rules with legacy rules ([\#11667](matrix-org/matrix-react-sdk#11667)). Fixes #26227. Contributed by @kerryarchibald. * Revert "Fix regression around FacePile with overflow (#11527)" ([\#11634](matrix-org/matrix-react-sdk#11634)). Fixes #26209. * Fix: Alignment Fixed ([\#11648](matrix-org/matrix-react-sdk#11648)). Fixes #26169. Contributed by @manancodes. * Fix: onFinished added which closes the menu ([\#11647](matrix-org/matrix-react-sdk#11647)). Fixes #25556. Contributed by @manancodes. * Don't start key backups when opening settings ([\#11640](matrix-org/matrix-react-sdk#11640)). * Fix add to space avatar text centering ([\#11643](matrix-org/matrix-react-sdk#11643)). Fixes #26154. * fix avatar styling in lightbox ([\#11641](matrix-org/matrix-react-sdk#11641)). Fixes #26196.

t3chguy added 8 commits October 11, 2023 14:42

Use Compound tooltips on MessageTimestamp to improve UX of date time …

0b3482b

…discovery Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Show io.element.late_event in MessageTimestamp when known

42867a8

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Update snapshot

84ed907

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 't3chguy/fix/25913' into t3chguy/fix/25913.1

251de35

Avoid needing new Compound changes

5e6d845

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Move groupers into their own directory

7f1d947

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Refactor date separator code to be more generic

8fb26e9

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Render timeline separator for late event groups

c502d68

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 12, 2023

Fix date used in copy

bdba475

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify October 12, 2023 09:16 View deployment

Update snapshot

b0bd25c

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify October 12, 2023 09:38 View deployment

t3chguy requested a review from nadonomy October 13, 2023 11:01

nadonomy suggested changes Oct 13, 2023

View reviewed changes

Move groupers into their own directory

63984f4

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy force-pushed the t3chguy/fix/25913.2 branch from 7f1d947 to 63984f4 Compare October 13, 2023 13:59

t3chguy added 2 commits October 16, 2023 08:54

Update copy

58836c4

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify October 16, 2023 08:02 View deployment

Update copy

2444620

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy requested a review from nadonomy October 16, 2023 08:08

github-actions bot deployed to Netlify October 16, 2023 08:08 View deployment

nadonomy approved these changes Oct 16, 2023

View reviewed changes

t3chguy added 2 commits October 16, 2023 09:28

Update snapshot

1c76cf0

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

f0d81b6

… t3chguy/fix/25913.3 # Conflicts: # src/components/views/messages/MessageTimestamp.tsx # src/components/views/rooms/EventTile.tsx

github-actions bot deployed to Netlify October 16, 2023 08:38 View deployment

Base automatically changed from t3chguy/fix/25913.2 to develop October 16, 2023 08:59

t3chguy added 2 commits October 16, 2023 10:02

Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into…

3eef51d

… t3chguy/fix/25913.3 # Conflicts: # src/components/structures/MessagePanel.tsx # src/components/structures/grouper/CreationGrouper.tsx # src/components/structures/grouper/MainGrouper.tsx

i18n

640c528

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy marked this pull request as ready for review October 16, 2023 09:04

t3chguy requested a review from a team as a code owner October 16, 2023 09:04

t3chguy requested review from germain-gg and florianduros October 16, 2023 09:04

github-actions bot deployed to Netlify October 16, 2023 09:08 View deployment

t3chguy enabled auto-merge October 16, 2023 09:47

germain-gg approved these changes Oct 16, 2023

View reviewed changes

t3chguy added this pull request to the merge queue Oct 16, 2023

t3chguy removed this pull request from the merge queue due to a manual request Oct 16, 2023

Add comments

7a9d81a

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

t3chguy enabled auto-merge October 16, 2023 13:31

Add comments

e3bee32

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions bot deployed to Netlify October 16, 2023 13:40 View deployment

t3chguy added this pull request to the merge queue Oct 16, 2023

Merged via the queue into develop with commit 5ff9651 Oct 16, 2023
21 checks passed

t3chguy deleted the t3chguy/fix/25913.3 branch October 16, 2023 15:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Render timeline separator for late event groups #11739

Render timeline separator for late event groups #11739

t3chguy commented Oct 12, 2023 •

edited by github-actions bot

Loading

nadonomy left a comment •

edited

Loading

nadonomy left a comment

germain-gg left a comment

germain-gg Oct 16, 2023

t3chguy Oct 16, 2023 •

edited

Loading

germain-gg Oct 16, 2023

t3chguy Oct 16, 2023

Render timeline separator for late event groups #11739

Render timeline separator for late event groups #11739

Conversation

t3chguy commented Oct 12, 2023 • edited by github-actions bot Loading

✨ Features

nadonomy left a comment • edited Loading

Choose a reason for hiding this comment

nadonomy left a comment

Choose a reason for hiding this comment

germain-gg left a comment

Choose a reason for hiding this comment

germain-gg Oct 16, 2023

Choose a reason for hiding this comment

t3chguy Oct 16, 2023 • edited Loading

Choose a reason for hiding this comment

germain-gg Oct 16, 2023

Choose a reason for hiding this comment

t3chguy Oct 16, 2023

Choose a reason for hiding this comment

t3chguy commented Oct 12, 2023 •

edited by github-actions bot

Loading

nadonomy left a comment •

edited

Loading

t3chguy Oct 16, 2023 •

edited

Loading