Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Update RoomSummaryCard navigation links #11812

Merged
merged 31 commits into from
Nov 16, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Oct 31, 2023

For element-hq/element-web#25883

This PR partially implements the new room details designs.

Not included in this PR:

  • tab navigation. Items only accessible from the right panel tab navigation have been added as normal menu items (files, people)
  • widget section
  • tab navigation header in subviews
Screenshot 2023-11-15 at 15 51 02 Screenshot 2023-11-15 at 15 50 29

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features

@germain-gg germain-gg added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Oct 31, 2023
@germain-gg germain-gg requested review from a team as code owners October 31, 2023 15:46
Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new sidebar looks really good 🎨

Should the widgets item not also be a new menu item? It does now look a bit out of place.

image

Also without using the new room header you can now no longer reach the member list. Designs use tabs here. Maybe as an intermediate solution we could add a „People“ item?

checked={isFavorite}
onClick={() => tagRoom(room, DefaultTagID.Favourite)}
/>
<MenuItem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disabled state is not reflected in the UI. It still looks like, that you can click the item:

image

Peek 2023-11-01 09-57

Tested in Matrix-HQ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-11-14 at 16 02 26

Fixed in compound 0.8.1

@americanrefugee
Copy link

I created a new disabled menu item state.

@kerryarchibald
Copy link
Contributor

hey @weeman1337, this is ready for another pass. thanks!

Copy link
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disabled buttons are now looking disabled 👍

Still the widgets actions are having a „link“ style:

image

Is there another issue to migrate the widget actions to the new menu design?

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the yarn.lock change

@kerryarchibald
Copy link
Contributor

@weeman1337 the widgets change is captured here, under the 'next iteration' epic https://github.com/vector-im/wat-internal/issues/77

@kerryarchibald kerryarchibald added this pull request to the merge queue Nov 16, 2023
Merged via the queue into develop with commit f96583e Nov 16, 2023
82 checks passed
@kerryarchibald kerryarchibald deleted the germain-gg/summary-card-links branch November 16, 2023 04:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants