This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fill cypress test high-level.spec.ts > A receipt for the last unimportant event makes the room read, even if all are unimportant
#11830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…portant event makes the room read, even if all are unimportant`
florianduros
added
the
T-Task
richvdh
reviewed
Nov 7, 2023
| @@ -168,7 +168,23 @@ describe("Read receipts", () => { | |||
| // The room is unread again | |||
| assertUnread(room2, 1); | |||
| }); | |||
| it.skip("A receipt for the last unimportant event makes the room read, even if all are unimportant", () => {}); | |||
| it("A receipt for the last unimportant event makes the room read, even if all are unimportant", () => { | |||
There was a problem hiding this comment.
I'm wondering if the intention of this test was that the room should start off unread?
@andybalaam as the guardian of these tests I think this is one for you
There was a problem hiding this comment.
No, this is just to say that unimportant events that are read don't make the room unread, so I think this is good modulo the comment I made.
andybalaam
suggested changes
Nov 7, 2023
| @@ -168,7 +168,23 @@ describe("Read receipts", () => { | |||
| // The room is unread again | |||
| assertUnread(room2, 1); | |||
| }); | |||
| it.skip("A receipt for the last unimportant event makes the room read, even if all are unimportant", () => {}); | |||
| it("A receipt for the last unimportant event makes the room read, even if all are unimportant", () => { | |||
There was a problem hiding this comment.
No, this is just to say that unimportant events that are read don't make the room unread, so I think this is good modulo the comment I made.
florianduros
deleted the
florianduros/unread/read-after-unimportant-messages
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fill cypress test
high-level.spec.ts>A receipt for the last unimportant event makes the room read, even if all are unimportantPart of element-hq/element-web#25449
This change is marked as an internal change (Task), so will not be included in the changelog.