Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Playwright: Fix thread root skipped tests #12067

Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Dec 18, 2023

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Part of element-hq/element-web#25449


This change is marked as an internal change (Task), so will not be included in the changelog.

@florianduros florianduros added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 18, 2023
@florianduros florianduros marked this pull request as ready for review December 18, 2023 16:48
@florianduros florianduros requested a review from a team as a code owner December 18, 2023 16:48
@dbkr
Copy link
Member

dbkr commented Dec 18, 2023

Why does the message get collapsed here?

@florianduros
Copy link
Contributor Author

Why does the message get collapsed here?

The root message, the thread, the room invitation are collapsed together. I assume that is the expected behavior. That's not the case ?

@dbkr
Copy link
Member

dbkr commented Dec 19, 2023

Oh I see: I guess it is expected, but worth a comment I think as it's not 100% obvious.

@florianduros florianduros added this pull request to the merge queue Dec 19, 2023
Merged via the queue into develop with commit 537b4a1 Dec 19, 2023
23 checks passed
@florianduros florianduros deleted the florianduros/unread/fix-redactions-thread-roots-tests branch December 19, 2023 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants