This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove deprecated calls to client#hasSecretStorageKey #12112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
added
the
T-Task
3 tasks
BillCarsonFr
force-pushed
the
valere/remove_deprecated_secret_storage_call
branch
from
6d48469
to
07a8835
Compare
BillCarsonFr
commented
Jan 8, 2024
| } else { | ||
| logger.log("Not setting dehydration key: feature disabled"); | ||
| } | ||
| await handleDeviceDehydration(cli); |
There was a problem hiding this comment.
I refactored this method following the sonar report about Cognitive Complexity. I noticed that the part that handles device dehydration is only done when 4s is already setup. When it's not and when the bootstrap is done by CreateSecretStorageDialog it's not called. There might be an issue here, but as device dehydration has changed (now dehydration v2) might not be worth checking it?
Base automatically changed from
valere/fix_reset_backup_after_verif
to
develop
January 10, 2024 11:27
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12098
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.