This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Linkify User Interactive Authentication errors #12271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
added
the
T-Enhancement
t3chguy
added
Z-Experiment
richvdh
suggested changes
Apr 8, 2024
Synapse does not yet return links in UIA responses but will as part of the work for https://github.com/element-hq/element-internal/issues/583 / element-hq/element-web#27045 |
richvdh
reviewed
Apr 11, 2024
| @@ -168,7 +170,9 @@ export default class InteractiveAuthDialog<T> extends React.Component<Interactiv | |||
| if (this.state.authError) { | |||
| content = ( | |||
| <div id="mx_Dialog_content"> | |||
| <div role="alert">{this.state.authError.message || this.state.authError.toString()}</div> | |||
| <Linkify options={linkifyMatrixOptions}> | |||
There was a problem hiding this comment.
For the record: I asked @t3chguy whether the fact that UIA error messages should be linkified was mentioned in an MSC anywhere. The answer is that it is not. But also, since this work is basically being done as a way of getting rid of UIA, MSCing it is probably not worthwhile.
(There is also precedent for EW linkifying things that are returned from the server, such as m.room.topics and timeline event bodies in general.)
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
|
Skipping code coverage due to splitting file to get around import cycle |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.