Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Tooltip: Use AccessibleButton in RovingAccessibleTooltipButton #12458

Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Apr 26, 2024

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Part of element-hq/element-web#26762
Following #12443, AccessibleButton includes the new tooltip. We are migrating step by step the usage of the deprecated AccessibleTooltipButton to AccessibleButton.

Use AccessibleButton in RovingAccessibleTooltipButton.

The RovingAccessibleTooltipButton usages will be replaced by RovingAccessibleButton after the AccessibleTooltipButton > AccessibleButton migration.

Playwright screenshot change is due to that the new tooltip is smaller than the old one and is not visible on the new screenshot.

@florianduros florianduros added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 26, 2024
@florianduros florianduros changed the title Tooltip: Use AccessibleButton in RovingAccessibleTooltipButton Tooltip: Use AccessibleButton in RovingAccessibleTooltipButton Apr 26, 2024
@florianduros florianduros changed the title Tooltip: Use AccessibleButton in RovingAccessibleTooltipButton Tooltip: Use AccessibleButton in RovingAccessibleTooltipButton Apr 26, 2024
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@florianduros florianduros added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@florianduros florianduros added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@t3chguy t3chguy added this pull request to the merge queue Apr 30, 2024
Merged via the queue into develop with commit 2df946b Apr 30, 2024
30 checks passed
@t3chguy t3chguy deleted the florianduros/tooltip/roving-accessible-tooltip-button branch April 30, 2024 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants