Get user pill profile remote data and show unrecognised rooms as links #1246
Conversation
Instead of relying on the local avatar/displayname of a user, request the data from the server and update the pill if it shows up. This required a slight refactor which means we're not doing everything in `render` now. Also I noticed unknown rooms weren't being rendered _at all_! So now you get something that looks like a normal link but with the room alias/ID in it.
lukebarnard1
changed the title
| const isUserPill = prefix === '@'; | ||
| const isRoomPill = prefix === '#' || prefix === '!'; | ||
| doProfileLookup: function(userId, member) { | ||
| MatrixClientPeg.get().getProfileInfo(userId).done((resp) => { |
There was a problem hiding this comment.
We should probably start using then in new code instead of done
| member.events.member = { | ||
| getContent: () => { | ||
| return {avatar_url: resp.avatar_url}; | ||
| }, |
There was a problem hiding this comment.
Ew for synthesising Member objects :(
There was a problem hiding this comment.
Totally agree but sadly, this is the only way to update the member with a users's profile information. The best thing to do would probably be to fish out the important stuff from the membership event when it gets set instead of storing it with the member? Or do both, and set extra fields when setting the event but that also feels ming.
Said fields could then be clobbered, leaving the event out-of-date but that's strictly accurate.
FTR RoomMember only hangs on to its member event for the purposes of being able to return the correct avatar URL... But who knows what other layers do with member.events.member
There was a problem hiding this comment.
Yeah - problem is that we're using something that takes only a Member object, but sometimes we don't have one because we're just displaying a general user rather than a member of a room.
| const isUserPill = prefix === '@'; | ||
| const isRoomPill = prefix === '#' || prefix === '!'; | ||
| doProfileLookup: function(userId, member) { | ||
| MatrixClientPeg.get().getProfileInfo(userId).done((resp) => { |
| switch (this.state.pillType) { | ||
| case Pill.TYPE_USER_MENTION: { | ||
| // If this user is not a member of this room, default to the empty member | ||
| // TODO: This could be improved by doing an async profile lookup |
I did think about this because |
…ix-react-sdk into luke/feature-async-pills
Instead of relying on the local avatar/displayname of a user, request the data from the server and update the pill if it shows up.
This required a slight refactor which means we're not doing everything in
rendernow. Also I noticed unknown rooms weren't being rendered at all! So now you get something that looks like a normal link but with the room alias/ID in it.