Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Check native sliding sync support against an unstable feature flag #12498

Merged
merged 3 commits into from
May 3, 2024
Merged

Check native sliding sync support against an unstable feature flag #12498

merged 3 commits into from
May 3, 2024

Commits on May 3, 2024

  1. Check native sliding sync support against an unstable feature flag 

    The `OPTIONS` approach from #12492 doesn't work because Synapse *always* responds with 204 (success) to `OPTIONS` requests, as described here: element-hq/synapse#17153

We further can't use `HEAD` because it's not part of the allowed CORS methods, meaning the browser will mask the exact status code and error message from us, and the proxy hangs on the request anyways: matrix-org/sliding-sync#429

To avoid these problems, we instead search for an unstable feature flag to be exposed by the server. Presence of this flag denotes native support. See https://github.com/matrix-org/matrix-spec-proposals/pull/3575/files#r1588877046 for details.

Implementations which support sliding sync natively will need to update to support this new unstable feature flag usage.
    @turt2live
    turt2live committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7470ed7 View commit details
    Browse the repository at this point in the history

  2. Appease the linter

    @turt2live
    turt2live committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2773a10 View commit details
    Browse the repository at this point in the history

  3. Appease the tests

    @turt2live
    turt2live committed May 3, 2024
    Configuration menu
    Copy the full SHA
    21c7b5f View commit details
    Browse the repository at this point in the history