Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add optional setting for hiding avatars in <Pill>s #1277

Merged
merged 2 commits into from
Aug 8, 2017

Conversation

lukebarnard1
Copy link
Contributor

@lukebarnard1 lukebarnard1 commented Aug 8, 2017

Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Lint
  2. Can we have settings default to 'on'? If so, I'd probably just make it 'show avatars' everywhere rather than having 'hide' in the UI and then negating it.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr Aug 8, 2017
@lukebarnard1
Copy link
Contributor Author

Can we have settings default to 'on'?

There's no mechanism for that currently. It's assumed that by default the checkbox is disabled. This aligns nicely with the setting not being in account data.

Arguably the UX could paper over that somehow, but we'd need to stop specifying the default value for each setting in every call to getSyncedSetting.

@dbkr
Copy link
Member

dbkr commented Aug 8, 2017

fair enough then

@dbkr dbkr merged commit ca22735 into develop Aug 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants