-
-
Notifications
You must be signed in to change notification settings - Fork 833
Conversation
Includes rudimentary support for custom statuses and user-controlled status. Some minor tweaks have also been made to better control how we advertise our presence. Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
049bcc8
to
24000ee
Compare
This is ready for review. I can't figure out the UX for custom away statuses in a sensible way, so I'm pushing that off to a later PR (potentially by someone else). |
hm, this is another one of these massive features that somehow I've totally missed the PR for - sorry :( we seem to be rather stretched on folks to check PRs atm. |
I'm slightly surprised that Synapse actually supports this, as I don't think anyone has ever actually used the custom presence support (although it was indeed implemented in the outset)... |
Presence.stopMaintainingStatus(); | ||
if (newStatus === "online") { | ||
Presence.setState(newStatus); | ||
} else Presence.setState(newStatus, null, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprised the linter doesn't complain bitterly about this - the codestyle is to avoid oneliner if & else blocks please :)
So this looks excellent :) Only thoughts are:
Otherwise this looks good to merge modulo minor style nitpick. |
I saw those designs somewhere, and I would agree the account picker is better suited elsewhere (possibly user settings post-tabbed-settings?). The MSN style behaviour is an intentional choice to mimic other applications, like Discord. The users show up as "Away" in the RHS. Much like "Idle", the user is 50% opacity. |
cool. again, i'm amazed that MemberInfo does the right thing - particularly as bits of the presence codebase try to use the terms 'away' and 'idle' interchangeably(!). lgtm - thanks! |
The feature is incredibly buggy and doesn't work as expected due to server behaviour and client interaction. One of the major problems is the constantly confused presence state - this is caused by the mobile apps conflicting on the state of the web app, causing it to consider the user offline or online (and rarely away) depending on how riot-android/ios is behaving at the time. This reverts two PRs: * matrix-org#1620 * matrix-org#1482 The changes to the context menu positioning were not reverted as they are useful outside of presence management. Signed-off-by: Travis Ralston <travpc@gmail.com>
The feature is incredibly buggy and doesn't work as expected due to server behaviour and client interaction. One of the major problems is the constantly confused presence state - this is caused by the mobile apps conflicting on the state of the web app, causing it to consider the user offline or online (and rarely away) depending on how riot-android/ios is behaving at the time. This reverts two PRs: * #1620 * #1482 The changes to the context menu positioning were not reverted as they are useful outside of presence management. Signed-off-by: Travis Ralston <travpc@gmail.com>
Required PRs / Related issues
Adds: https://github.com/vector-im/riot-web/issues/478 (NYI)Adds: Need UI/UX for setting custom presence status element-hq/element-web#1897 (NYI)Adds: https://github.com/vector-im/riot-web/issues/3996 (NYI)What it looks like