This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add option to mirror local video feed #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
reviewed
Oct 25, 2017
| @@ -108,14 +111,16 @@ module.exports = React.createClass({ | |||
| document.mozFullScreenElement || | |||
| document.webkitFullscreenElement); | |||
| const maxVideoHeight = fullscreenElement ? null : this.props.maxHeight; | |||
|
|
|||
| const localVideoFeedClasses = classNames("mx_VideoView_localVideoFeed", | |||
| {"mx_VideoView_localVideoFeed_flipped": UserSettingsStore.getSyncedSetting} | |||
There was a problem hiding this comment.
did you want to actually call this function?
dbkr
reviewed
Oct 26, 2017
| @@ -112,7 +112,9 @@ module.exports = React.createClass({ | |||
| document.webkitFullscreenElement); | |||
| const maxVideoHeight = fullscreenElement ? null : this.props.maxHeight; | |||
| const localVideoFeedClasses = classNames("mx_VideoView_localVideoFeed", | |||
| {"mx_VideoView_localVideoFeed_flipped": UserSettingsStore.getSyncedSetting} | |||
| { "mx_VideoView_localVideoFeed_flipped": | |||
| UserSettingsStore.getSyncedSetting('VideoView.flipVideoHorizontally'), | |||
There was a problem hiding this comment.
nitpick, but would be good to specify default false as the default default is null
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option that enables element-hq/element-web#5437