This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Persist pinned message open-ness between room switches #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses part of element-hq/element-web#5405 Signed-off-by: Travis Ralston <travpc@gmail.com>
turt2live
force-pushed
the
travis/persist-pinned-open
branch
from
beaa276
to
7526054
Compare
|
to me it would make sense to throw it into the RoomViewStore, since its part of the RoomView rather than settings |
|
The RoomViewStore doesn't persist anything between sessions as far as I can tell though. |
|
This pr is entitled between room switches, so I assumed that was the intent... |
|
Ah, sorry, it's meant to behave like the AppsDrawer, as mentioned in element-hq/element-web#5405 (comment) The AppsDrawer also remembers it's open state between sessions. |
dbkr
approved these changes
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of element-hq/element-web#5405