This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix showing peek preview while LL members are loading #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the peek item in element-hq/element-web#7182 |
|
Also this: element-hq/element-web#7209 |
8 tasks
…e latter doesnt take LL into account
dbkr
approved these changes
Aug 22, 2018
|
@dbkr that must be a mock missing that method, I'll fix it |
|
appears to be breaking on /develop - reverting while I work out why |
|
answer: |
dbkr
added a commit
to matrix-org/matrix-js-sdk
that referenced
this pull request
Aug 22, 2018
On Room, because it's super confusing that Room has getJoinedMembers() but not getJoinedMemberCount() matrix-org/matrix-react-sdk#2126 had assumed that this method was on Room
This was referenced Aug 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't been active in a room for a while, you might see the peek screen as your membership is not known. This fixes it by relying on room.getMyMembership which falls back to the sync response section a room appears in (invite, join, ...).