This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Render terms & conditions in settings #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If configured in config file
dbkr
changed the title
bwindels
reviewed
Aug 24, 2018
| _renderTermsAndConditionsLinks: function() { | ||
| if (SdkConfig.get().terms_and_conditions_links) { | ||
| const tncLinks = []; | ||
| for (const tncEntry of SdkConfig.get().terms_and_conditions_links) { |
There was a problem hiding this comment.
No need to check if terms_and_conditions_links is set here?
There was a problem hiding this comment.
Oops, you do above already :)
bwindels
reviewed
Aug 24, 2018
| _renderTermsAndConditionsLinks: function() { | ||
| if (SdkConfig.get().terms_and_conditions_links) { | ||
| const tncLinks = []; | ||
| for (const tncEntry of SdkConfig.get().terms_and_conditions_links) { |
There was a problem hiding this comment.
map would fit well here? But oh well ...
There was a problem hiding this comment.
yeah true - I suppose it doesn't make a lot of difference
bwindels
approved these changes
Aug 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If configured in config file
Fixes element-hq/element-web#7219