This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix: 'jump to bottom' creates big amounts of whitespace at the bottom #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element-hq/element-web#8392
To make sure the
min-heighton the timeline gets cleared when needed, do it onScrollPanel::componentDidUpdateif not at the bottom (we only care about a min-height (to avoid jumping when typing notifs disappear) when at the bottom). This should catch all cases when the timeline can shrink.Also don't clear the
min-heighton a new message when typing is not visible because this will still cause the timeline to shrink and jump up when a message comes in after the typing has disappeared.