-
-
Notifications
You must be signed in to change notification settings - Fork 833
Conversation
This makes it easier to theme via CSS, which helps with the dark theme.
(Push CI failure expected, I deleted the branch.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks okay, I think.
In future, please reference issues in the commits and provide a bit more detail in the commits for bulk PRs. It's nearly impossible to review the whole diff as one thing, thus somewhat forcing the reviewer to go commit by commit. Having the context of the issue and description of the change (as though it's a mini PR, in a way) helps make review easier. Alternatively, open up a bunch of smaller PRs with the same amount of detail.
Okay, will do! I normally prepare my PRs expecting people to look at each commit, as that's the way I am used to working and reviewing (with meaningful commits rather than 10 commits that say "fix"). However, it hasn't felt like people actually look at them when reviewing usually (since most other PR author's don't seem to expect that way of reviewing), so I've been a bit unsure if people would actually read the extra commit info, and as you can see here I didn't put much in each commit this time. I guess the best plan is to clarify in a PR how it is best reviewed to avoid confusion. Thanks for the review! 😁 |
Includes things like:
Fixes various pieces of element-hq/element-web#8554
Fixes element-hq/element-web#8584
Fixes element-hq/element-web#8587
Fixes element-hq/element-web#8673
Fixes element-hq/element-web#8637