This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow captchas on Riot desktop builds #2663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something I noticed in the issues was all the captcha issues were on Windows. Not sure if this will all fall over in production, but on a local environment: Windows 10 Pro seems fine. I haven't checked Windows 7 due to lack of environment, but it might be something we should check as part of the pre-release checklist. |
turt2live
approved these changes
Feb 19, 2019
This was referenced Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reCAPTCHA prompts now appear to load in Riot desktop builds, so we can improve the UX by showing them there, instead of bouncing people out to web for this.
Effectively fixes element-hq/element-web#8288 since they now work directly in desktop.