Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix favourites losing rooms and sorting weirdly #2674

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix favourites losing rooms and sorting weirdly #2674

merged 1 commit into from
Feb 21, 2019

Conversation

turt2live
Copy link
Member

By not flagging the room as inserted, we end up sorting it.

Fixes element-hq/element-web#8857

@turt2live
Fix favourites losing rooms and sorting weirdly
d662dcc 
By not flagging the room as inserted, we end up sorting it.

Fixes element-hq/element-web#8857
@turt2live turt2live requested a review from a team February 21, 2019 16:17
@turt2live turt2live mentioned this pull request Feb 21, 2019
Closed
bwindels
bwindels approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I still think this method is too big to grasp it somewhat easily, but let's see if this fixes the issue!

@turt2live
Copy link
Member Author

turt2live commented Feb 21, 2019 •
edited
Loading

I still think this method is too big to grasp it somewhat easily

Absolutely. It's horrible.

Edit: have opened element-hq/element-web#8861

@turt2live turt2live merged commit 86c49d5 into develop Feb 21, 2019
@turt2live turt2live deleted the travis/fix-favourites branch February 21, 2019 16:28
@turt2live turt2live mentioned this pull request Feb 21, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bwindels bwindels bwindels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @bwindels