This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add badges to breadcrumb rooms #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
suggested changes
Apr 2, 2019
|
|
||
| onRoomReceipt = (event, room) => { | ||
| if (this.state.rooms.map(r => r.room.roomId).includes(room.roomId)) { | ||
| this.forceUpdate(); |
There was a problem hiding this comment.
Can we put this in the state please and avoid forceUpdate? I know we do it elsewhere like this, but we should probably stop doing it :)
|
(blocking this on #2860 to avoid updating multiple PRs too often) |
turt2live
force-pushed
the
travis/breadcrumbs/badges
branch
from
ba9407b to
f73c32e
Compare
bwindels
approved these changes
Apr 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #2860 - see ba9407b
Fixes element-hq/element-web#8606
Event listeners are to make sure the counts update when conditions change.