This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove 'try the app' link from login #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#8384 This will be re-addressed in element-hq/element-web#9388 or similar. Because the implementation is undefined, the dead code is being removed instead of just left dead.
jryans
suggested changes
Apr 5, 2019
| loginIncorrect: false, | ||
| }); | ||
|
|
||
| this._loginLogic.loginAsGuest().then(function(data) { |
There was a problem hiding this comment.
It appears loginAsGuest is also now dead, so it should be removed as well I suppose?
There was a problem hiding this comment.
I'd rather not because of:
There was a problem hiding this comment.
although the code is the same... so... goodbye dead code I guess
jryans
approved these changes
Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8384
This will be re-addressed in element-hq/element-web#9388 or similar. Because the implementation is undefined, the dead code is being removed instead of just left dead.