Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix bug where email was not required where it shouldn't have been #2961

Merged
merged 2 commits into from
May 13, 2019
Merged

Fix bug where email was not required where it shouldn't have been #2961

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34990d1
Fix bug where email was not required where it shouldn't have been
dbkr May 13, 2019
59cefba
Typo
dbkr May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/views/auth/RegistrationForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
Copyright 2015, 2016 OpenMarket Ltd
Copyright 2017 Vector Creations Ltd
Copyright 2018 New Vector Ltd
Copyright 2018, 2019 New Vector Ltd

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -150,7 +150,11 @@ module.exports = React.createClass({
if (!field) {
continue;
}
field.validate({ allowEmpty: false });
// We must wait for these validations to finish before queueing
// up the setState below so our setState goes in the queue after
// all the setStates from these validate calls (that's how we
// know they've finished).
await field.validate({ allowEmpty: false });
}

// Validation and state updates are async, so we need to wait for them to complete
Expand Down