Add Spoilers as per MSC2010 #3018
Conversation
| { reason } | ||
| | ||
| <span className="mx_EventTile_spoiler_content"> | ||
| <span dangerouslySetInnerHTML={{ __html: this.props.contentHtml }} /> |
There was a problem hiding this comment.
This is pretty stupid. Soru had to pass the content as HTML as, apparently, react doesn't allow attaching a DOM node as child...does anyone know a cleaner solution?
|
This PR is ready for review |
There was a problem hiding this comment.
Generally looks fine - thank you! Can we get a screenshot in the PR description to make design overview a bit easier as well as ensure we have a reference for when/if this ever breaks visually.
We'll also need signoff for the changes - depending on where you are located you might be able to get away with using a pseudonym instead of your real name, if you prefer.
Soru thought signing each commit was sufficient? As for real name, soru is not willing to use it here. |
You can either sign off in commits or the PR. See the contributing doc for more details. It looks like your commits have a GPG signature / verified label, but that is not the same as "sign off". Sign off means adding the text As for name, I believe using a name you are comfortable with identifying you is sufficient for this purpose. Once the sign off is done, comment here and we can send this for another review round. Thanks! 😄 |
|
Okay, done, thank you! |
|
Visually this looks fine! Are we confident in whatever blur technique we're using behaving well across all browsers? |
|
this goes to develop, so let's see how bad it can possibly be in practice :p |
This PR adds spoiler support as to the still WIP matrix-org/matrix-spec-proposals#2010
Rendered example:
Signed-off-by: Sorunome mail@sorunome.de