This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
New composer: support forcing auto complete on name by hitting tab #3349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that's not what the slate impl does and it's not an improvement
so one can await if needed
and also for multiple transformations at once. This removes the need to call the update callback from `replaceRange()` as well
by replacing word before caret with pill-candidate and forcing auto complete
not ideal, but for now this prevents a crash at startup when a user-pill is persisted in local storage
before the insertPartsAt method would call the update callback on its own, but now we have the concept of a transformation session, so lets bring the API in line
as this is now called from the `transform` method, unused in this test
bwindels
force-pushed
the
bwindels/tab-complete-name
branch
from
808da9a
to
994bcb5
Compare
also add try/catch in _tabCompleteName so errors don't get swallowed
dbkr
reviewed
Aug 28, 2019
| @@ -27,6 +27,15 @@ limitations under the License. | |||
| white-space: nowrap; | |||
| } | |||
|
|
|||
| @keyframes visualbell { | |||
| from { background-color: #faa; } | |||
There was a problem hiding this comment.
should this be defined in the theme?
| &.mx_BasicMessageComposer_input_error { | ||
| animation: 0.2s visualbell; | ||
| } | ||
|
|
There was a problem hiding this comment.
also may want Nad to weigh in on the visual flash as it currently highlight the bit where the text box actually is which is normally not visible so looks a bit odd. Not sure what the best way would be to make it look better.
There was a problem hiding this comment.
Hmm, not sure. The intention was to have it exactly the same as before:
| // if (this.state.query === query) { | ||
| // return Promise.resolve(); | ||
| // } else { | ||
| // } |
|
the visualbell css animation is duplicated, which will be cleaned up when the slate editor is removed. |
dbkr
approved these changes
Aug 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements element-hq/element-web#10627