This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
EditMessageComposer: disable Save button until a change has been made #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
reviewed
Sep 9, 2019
turt2live
approved these changes
Sep 10, 2019
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy
force-pushed
the
t3chguy/disable_save_button_msg_edit_nochange
branch
from
fa20749
to
792b709
Compare
turt2live
approved these changes
Sep 11, 2019
|
Is there a cleaner way to rebase? Pull develop and push made the PR unclean for some reason this time around because it included all the pulled in commits for whatever reason |
|
usually merge develop into the feature branch. It creates a squiggly line if using gitkraken, but its fine eg: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10809
Also closes the edit event view if someone tries to send an edit which would not change the event at all, instead of doing nothing with no response to the user that their event would remain unchanged.
Signed-off-by: Michael Telatynski 7t3chguy@gmail.com