Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix SVG mask-image usage in a bunch of places for correct outlining #3589

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Nov 1, 2019

Fixes element-hq/element-web#11041
Fixes an issue with Pinned Messages button missing its indicator
Fixes height consistency of the buttons to the right of the composer

Before:
image

After (same room):
image

image
image

@t3chguy t3chguy requested a review from a team November 1, 2019 14:50
@turt2live
Copy link
Member

Fixes an issue with Pinned Messages button missing its indicator

I swear we had an issue for this but I can't find it (thought the keywords are fiddly).

@turt2live turt2live requested review from turt2live and removed request for a team November 1, 2019 15:23
@t3chguy t3chguy merged commit b3a64bb into develop Nov 4, 2019
@t3chguy t3chguy deleted the t3chguy/svg_outlines branch May 25, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No keyboard focus outline around image-masked AccessibleButtons
2 participants