This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Add testing flow to bootstrap secret storage #3640
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an testing button to the key backup panel which bootstraps the Secure Secret Storage system (and also cross-signing keys). Fixes element-hq/element-web#11212
CI failures look like package repo 502 errors, should be unrelated to the code. |
@jryans merging develop fixed the 502 problem, though the linter is unhappy as are the e2e tests. |
dbkr
reviewed
Nov 25, 2019
This is not part of any designs, so it may be short-lived, but it's quite handy for diagnosing issues with cross-signing at least while the feature is in development.
This adds dialogs for creating and accessing secret storage via a passphrase or recovery key. These flows are adapted from the ones used for key backup.
dbkr
reviewed
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just comments on key storage echoing those on js-sdk. Looking good!
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Show resolved
Hide resolved
src/components/views/dialogs/secretstorage/AccessSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Show resolved
Hide resolved
dbkr
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking fab - sorry about the back & forth and slight confusion over APIs.
No worries! 😄 Thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an testing button to the key backup panel which bootstraps the Secure
Secret Storage system (and also cross-signing keys).
Uses matrix-org/matrix-js-sdk#1079
Fixes element-hq/element-web#11212