Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add testing flow to bootstrap secret storage #3640

Merged
merged 29 commits into from
Dec 11, 2019
Merged

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Nov 20, 2019

This adds an testing button to the key backup panel which bootstraps the Secure
Secret Storage system (and also cross-signing keys).

2019-12-05 at 16 30

2019-12-05 at 16 31

2019-12-05 at 16 32

Uses matrix-org/matrix-js-sdk#1079
Fixes element-hq/element-web#11212

@jryans jryans requested a review from a team November 20, 2019 17:59
@jryans
Copy link
Collaborator Author

jryans commented Nov 20, 2019

CI failures look like package repo 502 errors, should be unrelated to the code.

@turt2live
Copy link
Member

@jryans merging develop fixed the 502 problem, though the linter is unhappy as are the e2e tests.

@dbkr dbkr requested review from dbkr and removed request for a team November 22, 2019 10:55
src/MatrixClientPeg.js Outdated Show resolved Hide resolved
@jryans jryans requested a review from dbkr December 5, 2019 16:38
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just comments on key storage echoing those on js-sdk. Looking good!

src/CrossSigningManager.js Outdated Show resolved Hide resolved
src/CrossSigningManager.js Outdated Show resolved Hide resolved
src/CrossSigningManager.js Outdated Show resolved Hide resolved
@jryans jryans requested a review from dbkr December 10, 2019 18:02
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fab - sorry about the back & forth and slight confusion over APIs.

@jryans
Copy link
Collaborator Author

jryans commented Dec 11, 2019

No worries! 😄 Thanks for the reviews!

@jryans jryans merged commit c2cd97f into develop Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up cross signing in key backup flow
3 participants