-
-
Notifications
You must be signed in to change notification settings - Fork 829
Wire up the invite targets dialog to a real composer and show selections #3815
Conversation
It's going to be used for future work in this area, but for this particular PR it isn't needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 😁 Broadly it looks good, but I think the SVGs need to be re-exported first.
@@ -0,0 +1,37 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am 95% confident this SVG can be much simpler (likely the filter and ~5 transforms can go away) if exported in a different way. @nadonomy should be able to make it happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the SVG supplied by Nad, though shoved through inkscape to fix some viewport problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and by shoved through inkscape I mean in a later PR it is shoved through inkscape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried mentioning the filter and transform layers to him? In the past, I believe he's been able to resolve it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I generally assume that the SVG is production ready from wherever I get it from. Will ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave the email avatar for #3819 just so I don't have merge conflicts across my own PRs.
For element-hq/element-web#11199
Note: this looks a bit funny because it also boostraps the dialog for 3PID/email support, but that was dropped from this PR due to diff size/scope. Should be followed shortly with a PR that makes it work.