This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove labs option to cache 'passphrase' #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(which actually meant SSSS secrets) Fixes element-hq/element-web#1392
t3chguy
approved these changes
Jun 18, 2020
richvdh
added a commit
that referenced
this pull request
Jul 11, 2024
Since #4789, this has just been an obscure way to write a test of a local variable.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
* Remove call to no-op `checkOwnCrossSigningTrust` this is a no-op on rust crypto * inline `SecurityManager.isCachingAllowed` Since #4789, this has just been an obscure way to write a test of a local variable. * Remove unused `CreateSecretStorageOpts.getKeyBackupPassphrase` parameter This is unused on rust crypto (cf matrix-org/matrix-js-sdk#4313)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(which actually meant SSSS secrets)
Fixes element-hq/element-web#13921