This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add multi language spell check #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2020
t3chguy
reviewed
Nov 29, 2020
SimonBrandner
commented
Dec 3, 2020
src/components/views/settings/tabs/user/GeneralUserSettingsTab.js
Outdated
Show resolved
Hide resolved
|
Thank you very much for implementing this. Really brilliant to see the addition of more spell check options and multiple languages available. |
jryans
suggested changes
Feb 18, 2021
jryans
reviewed
Feb 18, 2021
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
jryans
approved these changes
Mar 2, 2021
|
Nice! Thank you very much! |
This was referenced Mar 2, 2021
|
Having no spellcheck dictionaries means spellcheck is disabled? |
|
@thany, yep, it should, if I hadn't done any mistakes :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on these PRs: PR 1, PR 2.
This fixes #13317 and fixes #13543.
I figured that the best way to solve these problems is a multi-language spell check. This PR adds the ability to select multiple languages for the Electron spell-checker. This sadly doesn't work in the browser, therefore, the spell-check settings are hidden in the browser. This also allows disabling spell-checking in Electron completely by removing all languages from the settings.
Signed-off-by: Šimon Brandner simon.bra.ag@gmail.com