Ignore whitespace in email address check

[dennisroczek]

for the case you copy & paste the email address you misses whitespaces. A trim is already integrated in the RegistrationForm.

---

Here's what your changelog entry will look like:

✨ Features

• Ignore whitespace in email address check (#5623). Contributed by @dennisroczek.

[SimonBrandner]

@dennisroczek, please include a sign off as described here

[dennisroczek]

@dennisroczek, please include a sign off as described here

err, I always miss the -s part :-/

[jryans]

Hmm, I don't think we can accept as-is... There are various other components that call this same function which do not trim, so they would then have a confused idea of validity.

If you'd like to move forward here, I suggest visiting each component and checking how they should handle spaces.

[turt2live]

@dennisroczek apologies for the delayed reply here - are you able to take a look at this still?

[ankur12-1610]

@dennisroczek apologies for the delayed reply here - are you able to take a look at this still?

Can I get the issue that we're solving coz the issue isn't linked, I tried to find it but I was not able to do so?

[dennisroczek]

There was no bug report. I found the bug myself and simply tried to fix it. Sadly, haven't the time at all to do anything.

Feel free to overtake.

[ankur12-1610]

There was no bug report. I found the bug myself and simply tried to fix it. Sadly, haven't the time at all to do anything.

Feel free to overtake.

Is it possible for you to add a video or screenshot or something?

[turt2live]

I think the testing steps for this would be to try to register an account with email, adding spaces to the end.

[ankur12-1610]

I think the testing steps for this would be to try to register an account with email, adding spaces to the end.

Thanks, I'll do it and I'll create an issue for it first of all

[duxovni]

Would a simpler approach be to just tweak that form field in the UI so it ignores any attempts to input whitespace? As in, you press space and the field value doesn't change, you paste in a string containing spaces and the spaces get automatically removed. That should solve this issue without requiring code changes elsewhere, right? It also feels more syntactically correct in some ways; rather than accepting strings that aren't valid email addresses, we just force the input to be a valid email.

[ankur12-1610]

Would a simpler approach be to just tweak that form field in the UI so it ignores any attempts to input whitespace? As in, you press space and the field value doesn't change, you paste in a string containing spaces and the spaces get automatically removed. That should solve this issue without requiring code changes elsewhere, right? It also feels more syntactically correct in some ways; rather than accepting strings that aren't valid email addresses, we just force the input to be a valid email.

Yeah, actually I didn't get the chance to look at it, I'll look at it now.

This sounds a good idea to me I'll try to add some jquery or something like that so that even if the user enters the input it will convert it to null.

[turt2live]

We don't have a jquery dependency and wouldn't really want to add one to be honest - we can just keep trim() on the field handling.

[ankur12-1610]

We don't have a jquery dependency and wouldn't really want to add one to be honest - we can just keep trim() on the field handling.

Ok! I'll go with trim() then

[ankur12-1610]

I've raised the PR which solves this issue and is the continuation of this PR.
PR: #9027

[turt2live]

Closing in favour of #9027